Skip to content

Use constant value in imag implementation for real-valued data types #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

Use constant value in imag implementation for real-valued data types #2063

merged 2 commits into from
Apr 29, 2025

Conversation

ndgrigorian
Copy link
Collaborator

This PR proposes to add a constant_value of 0 to be used by the implementation of the element-wise kernel when the input is a real-valued data type

Slips in change to use is_complex_v in imag and real

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the use-constant-value-in-imag branch from 6cae791 to eb8d305 Compare April 28, 2025 08:10
antonwolfy
antonwolfy previously approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian, just a small nit below

@ndgrigorian ndgrigorian force-pushed the use-constant-value-in-imag branch from eb8d305 to 79d4e9f Compare April 28, 2025 16:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_165 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the use-constant-value-in-imag branch from 79d4e9f to b909228 Compare April 29, 2025 19:14
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 86.419%. remained the same
when pulling b909228 on use-constant-value-in-imag
into a54dd82 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_169 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@ndgrigorian ndgrigorian merged commit b7a6b67 into master Apr 29, 2025
75 of 76 checks passed
@ndgrigorian ndgrigorian deleted the use-constant-value-in-imag branch April 29, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @antonwolfy